On 08/12/15 17:15, Ian Campbell wrote: > On Tue, 2015-12-01 at 11:53 +0000, George Dunlap wrote: >> Return proper error codes on failure so that scripts can tell whether >> the command completed properly or not. >> >> Also while we're at it, normalize init and dispose of >> libxl_device_disk structures. This means calling init and dispose in >> the actual functions where they are declared. >> >> This in turn means changing parse_disk_config_multistring() to not >> call libxl_device_disk_init. And that in turn means changes to >> callers of parse_disk_config(). >> >> It also means removing libxl_device_disk_init() from >> libxl.c:libxl_vdev_to_device_disk(). This is only called from >> xl_cmdimpl.c. > > ... and the ocaml bindings. > > I can't remember what we decided regarding libxl "getter" functions and > initialisation of the data type (i.e. whose responsibility it is), but it > seems that changing a given calls semantics is rather dangerous API-wise.
Right -- looks like there are similar issues with the nic lookup routines as well. I'll drop that bit from the patch. -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
