On Tue, 2016-01-12 at 18:31 +0000, Ian Jackson wrote: > > > +static char *usb_interface_xenstore_encode(libxl__gc *gc, const char > > *busid) > > +{ > > + char *str = libxl__strdup(gc, busid); > > + int i, len = strlen(str); > > + > > + for (i = 0; i < len; i++) { > > + if (str[i] == '.') > > + str[i] = '_'; > > + if (str[i] == ':') > > + str[i] = '@'; > > I know I'm late with this comment and it's trivial and my > comaintainers may disagree, but I would find this > > + if (str[i] == '.') str[i] = '_'; > + if (str[i] == ':') str[i] = '@'; > > clearer because the layout reflects the regular structure of the code. > But please don't change this until another maintainer has commented > and said whether they agree with me. Certainly this is observation of > mine does not block this patch.
I would lean towards the layout Ian suggests too. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel