>>> On 15.01.16 at 15:59, <roger....@citrix.com> wrote: > --- a/xen/arch/x86/domain.c > +++ b/xen/arch/x86/domain.c > @@ -542,8 +542,9 @@ int arch_domain_create(struct domain *d, unsigned int > domcr_flags, > d->domain_id, config->emulation_flags); > return -EINVAL; > } > - if ( config->emulation_flags != 0 && > - (!is_hvm_domain(d) || config->emulation_flags != > XEN_X86_EMU_ALL) ) > + if ( (is_hvm_domain(d) && config->emulation_flags != XEN_X86_EMU_ALL > && > + config->emulation_flags != 0) || > + (!is_hvm_domain(d) && config->emulation_flags != > XEN_X86_EMU_PIT) )
IMO it would be more readable when transforming if ( (a && b) || (!a && c) ) into if ( a ? b : c ) With that change Acked-by: Jan Beulich <jbeul...@suse.com> Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel