>>> On 19.01.16 at 09:43, <zhaoshengl...@huawei.com> wrote: > > On 2016/1/19 16:39, Jan Beulich wrote: >>>>> On 19.01.16 at 04:36, <zhaoshengl...@huawei.com> wrote: >>> > >>> > On 2016/1/18 18:40, Jan Beulich wrote: >>>>>>> >>>>> On 16.01.16 at 06:01, <zhaoshengl...@huawei.com> wrote: >>>>>> >>> > From: Shannon Zhao <shannon.z...@linaro.org> >>>>>> >>> > >>>>>> >>> > Since we will add ACPI initialization for UART in this file later, >>>>>> >>> > rename it with a generic name. >>>>>> >>> > >>>>>> >>> > Signed-off-by: Shannon Zhao <shannon.z...@linaro.org> >>>>>> >>> > --- >>>>>> >>> > v4: split the original patch to renaming this and adding ACPI >>>>>> >>> > parts. >>>>>> >>> > --- >>>>>> >>> > MAINTAINERS | 2 +- >>>>>> >>> > xen/drivers/char/Makefile | 2 +- >>>>>> >>> > xen/drivers/char/arm-uart.c | 107 > ++++++++++++++++++++++++++++++++++++++++++++ >>>>>> >>> > xen/drivers/char/dt-uart.c | 107 >>>>>> >>> > -------------------------------------------- >>>>>> >>> > 4 files changed, 109 insertions(+), 109 deletions(-) >>>>>> >>> > create mode 100644 xen/drivers/char/arm-uart.c >>>>>> >>> > delete mode 100644 xen/drivers/char/dt-uart.c >>>> >> Looks like this really is a rename with little actual changes to >>>> >> the file, >>> > Yes, but the only change to this file is also to change its name because >>> > it's mentioned in the file header. This intends to make that consistent. >>> > >>> > + * xen/drivers/char/arm-uart.c >> I understand that, but without using git's ability to represent the >> rename such that the diff between the files is visible it is hard to >> tell what exactly you changed in the file. > Yes, from the git diffstat it's hard to tell the truth. I will add some > words in the commit message.
That's not the point; the point is that if you already use git to create the patch, you should also use the needed option to make git represent the patch in a way the change-and-rename gets reflected suitably. If you weren't using git to create the patch I'd be fine with the actual change(s) just being mentioned in the commit message. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
