On 09/02/16 12:43, Jan Beulich wrote:
>>>> On 08.02.16 at 18:07, <andrew.coop...@citrix.com> wrote:
>> --- a/xen/arch/x86/xen.lds.S
>> +++ b/xen/arch/x86/xen.lds.S
>> @@ -120,6 +120,12 @@ SECTIONS
>> .init.data : {
>> *(.init.rodata)
>> *(.init.rodata.str*)
>> +
>> + . = ALIGN(32);
> Why 32?
>
>> + __setup_start = .;
>> + *(.init.setup)
>> + __setup_end = .;
>> +
>> *(.init.data)
>> *(.init.data.rel)
>> *(.init.data.rel.*)
>> @@ -146,11 +152,6 @@ SECTIONS
>> __ctors_end = .;
>> } :text
>> . = ALIGN(32);
>> - .init.setup : {
>> - __setup_start = .;
>> - *(.init.setup)
>> - __setup_end = .;
>> - } :text
> If just because it was 32 here, I don't think that's a compelling
> reason. With it (above, not necessarily here) reduced to 8 (which
> of course could also be done while committing, if you agree and
> there are no deeper reasons),
> Reviewed-by: Jan Beulich <jbeul...@suse.com>
It was just because of the code here. I still can't think of any
specific reason why 32 is needed, so the ALIGN() can just be dropped.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
