On Mon, 15 Feb 2016, Jan Beulich wrote: > >>> On 15.02.16 at 07:37, <cz...@bitdefender.com> wrote: > > default: > > - return -EOPNOTSUPP; > > + /* > > + * Should not be reached unless arch_monitor_get_capabilities() is > > not > > + * properly implemented. In that case, since reaching this point > > does > > + * not really break anything, don't crash the hypervisor, issue a > > + * warning instead of BUG(). > > + */ > > + printk(XENLOG_WARNING > > + "WARNING, BUG: arch_monitor_get_capabilities() not > > implemented" > > + "properly.\n"); > > > > - }; > > + return -EOPNOTSUPP; > > + } > > I disagree with the issuing of a message here. At the very least this > should be a dprintk(). Perhaps an ASSERT_UNREACHABLE() would be > the way to go? What's worse though is that I can't see the checking > which would make true the "should not be reached" statement above > (not that you must not rely on the caller of the hypercall to be well > behaved).
ASSERT_UNREACHABLE() is appropriate here _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
