On Mon, 2016-02-15 at 11:51 -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Feb 05, 2016 at 07:35:22PM +0100, Dario Faggioli wrote:
> >
> > @@ -7559,6 +7546,14 @@ void sched_summary_domain(struct domain_data
> > *d)
> > }
> > }
> >
> > +void dump_sched_vcpu_action(struct record_info *ri, const char
> > *action)
> > +{
> > + struct {
> > + unsigned int domid, vcpuid;
> > + } * r = (typeof(r))ri->d;
> > +
> > + printf(" %s %s d%uv%u\n", ri->dump_header, action, r->domid,
> > r->vcpuid);
> > +}
>
> I know that 'sched_switch_process' used to have '} * r =' type but
> there
> are different pieces of code that do: "} *r ="
> (mem_pod_zero_reclaim_process)
>
Ah, good point. I did not notice that, as, as you say, I just
moved/replicated what I found in sched_switch_process.> Could all of the patches use the '*r = ' style? There are more of > them: > > [konrad@x230 xentrace]$ cat xenalyze.c | grep "} \*r =" | wc > 32 128 942 > [konrad@x230 xentrace]$ cat xenalyze.c | grep "} \* r =" | wc > 3 17 92 > Yep, I'll do this. > Besides that: > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > Thanks. > on this and the other patches that touch xenalyze.c (that is with the > modification to * r = .. > Sure! Regards, Dario -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
