On Mon, 29 Feb 2016, Jan Beulich wrote: > >>> On 29.02.16 at 15:25, <stefano.stabell...@eu.citrix.com> wrote: > > On Mon, 29 Feb 2016, Jan Beulich wrote: > >> Also it doesn't look very nice to me to (ab)use xz's CRC32 code > >> here; I don't know who has suggested doing so. > > > > It was suggested by Julien. > > > > I agree that including ../../../common/xz/crc32.c seems a bit fragile > > but introducing another copy of xz_crc32 seems even worse to me (see > > http://marc.info/?l=xen-devel&m=144775375427921&w=2). Maybe you have a > > better suggestion? > > Well, at some point there was talk of ARM not wanting to > ExitBootServices() as early as x86 does. In that case there > would be a CRC32 function among the various boot services > ones. > > The other option would be to have a generic crc32() function, > and maybe make xz use it.
Either way seems good to me. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
