Harmandeep Kaur writes ("[PATCH v4] libxl: handle failure of xc_version() in
libxl_get_version_info()"):
> Check the return value of xc_version() and return NULL if it
> fails. libxl_get_version_info() can also return NULL now.
>
> Callers of the function libxl_get_version_info() are already
> prepared to deal with a NULL return value.
Thanks for your submission.
> long xen_version;
> + long r = 0;
Why did you choose `long' for the type of `r' ? Normally it would be
an int and AFAICT xc_version returns int.
> v3: Group all calls to xc_version() , so that data copies in
> various info fields only if all calls to xc_version work.
This should be in the main part of the commit message, and also the
explanation of why it is necessary.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
