Jan Beulich writes ("Re: [Xen-devel] [PATCH v3] xen/errno: Reduce complexity of inclusion"): > On 04.03.16 at 13:50, <andrew.coop...@citrix.com> wrote: > > IMO, it is wrong to undef XEN_ERRNO if it was provided from external scope. > > Well, even if not written down, that's the intended behavior: The > use case for the including file to further need that definition is > rather hard to see, whereas use cases for the including file > wanting to do multiple inclusion are quite easy to construct, and > in that case the including file would needlessly be forced to > repeatedly #undef the symbol.
This is really a very bikeshed issue, but: I slightly prefer Jan's argument here to Andrew's. I think that this overall patch from Andrew is very helpful and I would like to see this minor issue resolved. Andrew, would you be able to revise the header to #undef XEN_ERRNO in this case ? Naturally this would want to be documented, in your admirable new doc comment. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel