On Wed, 2016-03-16 at 11:47 -0500, Chong Li wrote: > Add xc_sched_rtds_vcpu_get/set functions to interact with > Xen to get/set a domain's per-VCPU parameters. > Patch is ok, IMO, with only two minor comments.
First, the subject is a bit long. I'd go for:
"libxc: enable per-VCPU parameters for RTDS"
Second, here...
> Signed-off-by: Chong Li <chong...@wustl.edu>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xis...@gmail.com>
> --- a/tools/libxc/xc_rt.c
> +++ b/tools/libxc/xc_rt.c
> @@ -62,3 +62,71 @@ int xc_sched_rtds_domain_get(xc_interface *xch,
>
> return rc;
> }
> +
> +int xc_sched_rtds_vcpu_set(xc_interface *xch,
> + uint32_t domid,
> + struct xen_domctl_schedparam_vcpu *vcpus,
> + uint32_t num_vcpus)
> +{
> + int rc = 0;
>
rc does not need to be initialized to 0 (and hence it shouldn't be).
Even with only this fixed (i.e., even if the subject stays as it is):
Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>
Thanks and Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
