Konrad Rzeszutek Wilk writes ("[PATCH v4 08/34] vmap: Make the while loop less fishy."): > error: > - while ( i-- ) > - free_domheap_page(mfn_to_page(mfn_x(mfn[i]))); > + while ( i ) > + free_domheap_page(mfn_to_page(mfn_x(mfn[--i])));
I quite strongly dislike this. It is good practice to keep the loop control code together where this is reasonably convenient. I wouldn't quibble on such a stylistic matter (particularly outside my bailiwick) but (a) I would like to reinforce Jan's position and (b) it seems worth writing an email as there will be many occurrences. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel