On Thu, Mar 31, 2016 at 11:59:45PM -0500, Chong Li wrote:
> Add libxl_vcpu_sched_params_get/set and sched_rtds_vcpu_get/set
> functions to support per-VCPU settings.
>
> Signed-off-by: Chong Li <chong...@wustl.edu>
> Signed-off-by: Meng Xu <men...@cis.upenn.edu>
> Signed-off-by: Sisu Xi <xis...@gmail.com>
>
> Acked-by: Wei Liu <wei.l...@citrix.com>
This should have been dropped.
> Reviewed-by: Dario Faggioli <dario.faggi...@citrix.com>
> ---
> Changes on PATCH v8:
> 1) Add libxl_vcpu_sched_params_get_all() and
> sched_rtds_vcpu_get_all() to output all vcpus of a domain.
>
[...]
>
> +int libxl_vcpu_sched_params_get(libxl_ctx *ctx, uint32_t domid,
> + libxl_vcpu_sched_params *scinfo)
> +{
> + GC_INIT(ctx);
> + int rc;
> +
> + scinfo->sched = libxl__domain_scheduler(gc, domid);
> +
> + switch (scinfo->sched) {
> + case LIBXL_SCHEDULER_SEDF:
> + LOG(ERROR, "SEDF scheduler is no longer available");
> + rc = ERROR_FEATURE_REMOVED;
> + break;
> + case LIBXL_SCHEDULER_CREDIT:
> + case LIBXL_SCHEDULER_CREDIT2:
> + case LIBXL_SCHEDULER_ARINC653:
> + LOG(ERROR, "per-VCPU parameter getting not supported for this
> scheduler");
> + rc = ERROR_INVAL;
> + break;
> + case LIBXL_SCHEDULER_RTDS:
> + rc = sched_rtds_vcpu_get(gc, domid, scinfo);
> + break;
> + default:
> + LOG(ERROR, "Unknown scheduler");
> + rc = ERROR_INVAL;
> + break;
> + }
> +
> + GC_FREE;
> + return rc;
> +}
> +
> +int libxl_vcpu_sched_params_get_all(libxl_ctx *ctx, uint32_t domid,
> + libxl_vcpu_sched_params *scinfo)
> +{
> + GC_INIT(ctx);
> + int rc;
> +
> + scinfo->sched = libxl__domain_scheduler(gc, domid);
> +
> + switch (scinfo->sched) {
> + case LIBXL_SCHEDULER_SEDF:
> + LOG(ERROR, "SEDF scheduler is no longer available");
> + rc = ERROR_FEATURE_REMOVED;
> + break;
> + case LIBXL_SCHEDULER_CREDIT:
> + case LIBXL_SCHEDULER_CREDIT2:
> + case LIBXL_SCHEDULER_ARINC653:
> + LOG(ERROR, "per-VCPU parameter getting not supported for this
> scheduler");
> + rc = ERROR_INVAL;
> + break;
> + case LIBXL_SCHEDULER_RTDS:
> + rc = sched_rtds_vcpu_get_all(gc, domid, scinfo);
> + break;
> + default:
> + LOG(ERROR, "Unknown scheduler");
> + rc = ERROR_INVAL;
> + break;
> + }
> +
> + GC_FREE;
> + return rc;
> +}
> +
These two functions LGTM, so I shall ack this patch again:
Acked-by: Wei Liu <wei.l...@citrix.com>
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
