On Tue, 5 Apr 2016, Juergen Gross wrote: > On 04/04/16 18:48, Boris Ostrovsky wrote: > > On 04/04/2016 12:30 PM, David Vrabel wrote: > >> On 04/04/16 17:21, Julien Grall wrote: > >>> (CC Stefano new e-mail address) > >>> > >>> Hello Anna-Maria, > >>> > >>> On 04/04/2016 13:32, Anna-Maria Gleixner wrote: > >>>> Xen guests do not offline/online CPUs during suspend/resume and > >>>> therefore FROZEN notifier transitions are not required. Add this > >>>> explanation as a comment in the code to get not confused why > >>>> CPU_TASKS_FROZEN masked transitions are not considered. > >> Alternatively, these could be added even if they are not encountered. > >> This might be more future-proof but the documentation might be clearer. > >> > >> Boris, Juergen, any opinion? > > I'd rather do more than a comment: > > Either mask CPU_TASKS_FROZEN from action if it really doesn't matter > whether the flag is set or not (which IMHO is the case here), or > BUG_ON(action & CPU_TASKS_FROZEN) if this really should never happen.
I agree _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
