Chun Yan Liu writes ("Re: [PATCH 1/4] a fix in libxl_device_usbdev_list"):
> On 4/8/2016 at 12:45 AM, in message
> <22278.36492.245114.295...@mariner.uk.xensource.com>, Ian Jackson
> <ian.jack...@eu.citrix.com> wrote:
> > If libxl__device_usbdev_list_for_usbctrl fails, shouldn't
> > libxl_device_usbdev_list fail too ?
>
> Following the similar definitions of other device types, the return value of
> this function is "libxl_device_usbdev *", to treat the above case as failure,
> it cannot be reflected through return value, we can only set return value
> to NULL, but that will be confusing with a real no-device case.
Urk. Yes, you're right. *sigh*
We won't fix that bad API pattern for 4.7. So
Acked-by: Ian Jackson <ian.jack...@eu.citrix.com>
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
