>>> Razvan Cojocaru <rcojoc...@bitdefender.com> 04/14/16 11:08 AM >>> >On 04/14/2016 08:56 AM, Razvan Cojocaru wrote: >>>> --- a/xen/arch/x86/mm.c >>>> >> +++ b/xen/arch/x86/mm.c >>>> >> @@ -112,6 +112,7 @@ >>> > >#include <asm/ldt.h> >>> > >#include <asm/x86_emulate.h> >>> > >#include <asm/e820.h> >>>> >> +#include <asm/hvm/emulate.h> >>> > >>> > This header shouldn't be included here. You need to move the declarations >>> > elsewhere for them to be usable here. >> Understood. Is there any place particularly fitting you could suggest? > >Actually, I've removed that #include and the code continues to compile, >so it would appear that it is somehow #included indirectly, which makes >the declarations accessible implicitly.
But - see my other reply just sent - it is _still_ the wrong header then. Stuff shared between PV and HVM doesn't belong in HVM specific files. There are a few counterexamples, but we shouldn't add more. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
