On April 25, 2016 9:58pm, <julien.gr...@arm.com> wrote: > On 25/04/16 12:52, Jan Beulich wrote: > >>>> On 18.04.16 at 16:00, <quan...@intel.com> wrote: > >> --- a/xen/drivers/passthrough/arm/smmu.c > >> +++ b/xen/drivers/passthrough/arm/smmu.c > >> @@ -2540,7 +2540,7 @@ static int force_stage = 2; > >> */ > >> static u32 platform_features = ARM_SMMU_FEAT_COHERENT_WALK; > >> > >> -static void arm_smmu_iotlb_flush_all(struct domain *d) > >> +static int arm_smmu_iotlb_flush_all(struct domain *d) > >> { > >> struct arm_smmu_xen_domain *smmu_domain = > domain_hvm_iommu(d)->arch.priv; > >> struct iommu_domain *cfg; > >> @@ -2557,13 +2557,15 @@ static void arm_smmu_iotlb_flush_all(struct > domain *d) > >> arm_smmu_tlb_inv_context(cfg->priv); > >> } > >> spin_unlock(&smmu_domain->lock); > >> + > >> + return 0; > >> } > > > > Even if indentation looks inconsistent in this file, please make your > > addition match surrounding code. > > The file smmu.c was imported from Linux and supposed to use only Linux > coding style. This is in order to help porting fixes. >
Julien, A 'tab' ? Quan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel