On Fri, Apr 29, 2016 at 04:21:18PM +0200, Roger Pau Monne wrote:
> Some error paths incorrectly used rc instead of errno.
>
> Signed-off-by: Roger Pau Monné <[email protected]>
> ---
> Cc: Konrad Rzeszutek Wilk <[email protected]>
> Cc: Ross Lagerwall <[email protected]>
> Cc: Ian Jackson <[email protected]>
> Cc: Wei Liu <[email protected]>
> ---
> tools/misc/xen-xsplice.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/misc/xen-xsplice.c b/tools/misc/xen-xsplice.c
> index 0f1ab5a..695be7f 100644
> --- a/tools/misc/xen-xsplice.c
> +++ b/tools/misc/xen-xsplice.c
> @@ -273,7 +273,7 @@ int action_func(int argc, char *argv[], unsigned int idx)
> if ( rc )
> {
> fprintf(stderr, "%s failed to get status (rc=%d, %s)!\n",
I think it is better to also change rc= to errno= here.
> - name, -rc, strerror(-rc));
> + name, errno, strerror(errno));
> return -1;
> }
> if ( status.rc == -EAGAIN )
> @@ -295,7 +295,8 @@ int action_func(int argc, char *argv[], unsigned int idx)
> rc = action_options[idx].function(xch, name, 0);
> if ( rc )
> {
> - fprintf(stderr, "%s failed with %d(%s)\n", name, -rc,
> strerror(-rc));
> + fprintf(stderr, "%s failed with %d(%s)\n", name, errno,
> + strerror(errno));
> return -1;
> }
> }
> --
> 2.6.4 (Apple Git-63)
>
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel
