> -----Original Message----- > From: suravee.suthikulpa...@amd.com > [mailto:suravee.suthikulpa...@amd.com] > Sent: 22 May 2016 00:42 > To: xen-devel@lists.xen.org; Paul Durrant; jbeul...@suse.com; George > Dunlap > Cc: Keir (Xen.org); Suravee Suthikulpanit; Suravee Suthikulpanit > Subject: [PATCH v3 1/3] x86/hvm: Add check when register io handler > > From: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > > At the time of registering HVM I/O handler, the HVM domain might > not have been initialized, which means the hvm_domain.io_handler > would be NULL. In the hvm_next_io_handler(), this should be asserted. > > Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > --- > xen/arch/x86/hvm/intercept.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/x86/hvm/intercept.c b/xen/arch/x86/hvm/intercept.c > index fc757d0..2f8d57f 100644 > --- a/xen/arch/x86/hvm/intercept.c > +++ b/xen/arch/x86/hvm/intercept.c > @@ -258,6 +258,8 @@ struct hvm_io_handler *hvm_next_io_handler(struct > domain *d) > { > unsigned int i = d->arch.hvm_domain.io_handler_count++; > > + ASSERT( d->arch.hvm_domain.io_handler );
Needs fixing for style, but with that... Reviewed-by: Paul Durrant <paul.durr...@citrix.com> > + > if ( i == NR_IO_HANDLERS ) > { > domain_crash(d); > -- > 1.9.1 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel