On 2016/6/7 19:36, Julien Grall wrote: > > > On 07/06/16 12:30, Shannon Zhao wrote: >> On 2016/6/7 19:19, Julien Grall wrote: >>> On 31/05/16 06:02, Shannon Zhao wrote: >>>> +static void make_acpi_gtdt(libxl__gc *gc, struct xc_dom_image *dom) >>>> +{ >>>> + struct acpi_gtdt_descriptor *gtdt; >>>> + >>>> + gtdt = libxl__zalloc(gc, sizeof(*gtdt)); >>>> + >>>> + gtdt->secure_el1_interrupt = GUEST_TIMER_PHYS_S_PPI; >>>> + gtdt->secure_el1_flags = (ACPI_LEVEL_SENSITIVE << >>>> ACPI_GTDT_INTERRUPT_MODE) >>>> + |(ACPI_ACTIVE_LOW << >>>> ACPI_GTDT_INTERRUPT_POLARITY); >>> >>> There is no secure EL1 for guest, so this should be 0. >>> >> So why does DT add secure EL1 timer in make_timer_node()? > > Because the DT binding mandates the secure EL1 IRQ. However this > interrupt will never be asserted by the virtual timer. Oh, right. But it's harmless. Anyway, I'll remove this.
-- Shannon _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel