On Wed, Jun 15, 2016 at 02:14:15AM -0600, Jan Beulich wrote: > >>> On 14.06.16 at 18:33, <konrad.w...@oracle.com> wrote: > >> + /* Check for continuation if it's not the last iteration. */ > >> + if ( limit > ++bulk->start && hypercall_preempt_check() ) > > > > I surprised the compiler didn't complain to you about lack of parenthesis. > > I'm puzzled - what kind of warning would you expect here? The > compiler - afaik - treats relational operators vs logical AND/OR as > having well known precedence wrt to one another; what iirc it > would warn about is lack of parentheses in an expression using > both of the logical operators, as people frequently don't know > that && has higher precedence than ||.
Maybe those are the warnings I had seen in the past. I recall that with a more modern compiler it would give me suggestions to use parenthesis. But I honestly can't recall the details. Either way - the code is fine. > > Jan > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel
