Hi Wei, On 07/07/16 17:07, Wei Liu wrote:
On Tue, Jul 05, 2016 at 11:12:36AM +0800, Shannon Zhao wrote:int libxl__prepare_acpi(libxl__gc *gc, libxl_domain_build_info *info, libxl__domain_build_state *state, struct xc_dom_image *dom) { const libxl_version_info *vers; + int rc; + struct acpitable acpitables[NUMS]; + + /* convenience aliases */ + xc_domain_configuration_t *xc_config = &state->config;Julien seemed to have suggested this structure shouldn't be used. Did I misremember?
On the previous version, I said we should not extend this structure for parameter which is not used by the hypervisor (e.g the hypervisor does not need to know whether the guest will use ACPI).
However, this structure have to be used to get the version of the GIC that will be emulated for the guest. This is because the hypervisor might choose the version if the user did not specify one.
Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
