On 28/07/16 18:36, Tamas K Lengyel wrote:
On Thu, Jul 28, 2016 at 11:29 AM, Tamas K Lengyel <ta...@tklengyel.com> wrote:
On Thu, Jul 28, 2016 at 8:51 AM, Julien Grall <julien.gr...@arm.com> wrote:
__p2m_lookup is just a wrapper to p2m_get_entry.

Signed-off-by: Julien Grall <julien.gr...@arm.com>
Cc: Razvan Cojocaru <rcojoc...@bitdefender.com>
Cc: Tamas K Lengyel <ta...@tklengyel.com>

---
    It might be possible to rework the memaccess code to take advantage
    of all the parameters. I will defer this to the memaccess folks.

Could you elaborate on what you mean?


Never mind, I see it. Yes, doing __p2m_get_mem_access and then
p2m_get_entry later duplicates work. I would suggest just replacing
__p2m_get_mem_access with a single call to p2m_get_entry to get both
the type and the mem_access setting on the page in a single run.

I am not planning to clean-up the memaccess code. Feel free to send a follow-up patch for that.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Reply via email to