On 04/08/16 10:37, George Dunlap wrote: > One of the common ways in which contributors trip up over the > CODING_STYLE guides is by not putting a full stop at the end of a > comment when there is only a single sentence. Calling these out is a > waste of everybody's time: The full stop at the end of a comment with > a single sentence (or a single phrase) adds absolutely nothing to the > legibility of the code. > > Modify CODING_STYLE to allow comments with a single sentence or > sentence fragment to either have a full stop or not, while making it > clear that comments with multiple sentences must have a full stop at > the end of each sentence. > > Signed-off-by: George Dunlap <george.dun...@citrix.com>
Quoting myself from another thread: --- I think the issue here as that to me, these kinds of comments are not "plain written text"; they're more like signs or labels. If you search Google Images for "sign" or "clothing label", you'll find that no single-sentence signs have full stops at the end. That's why to me it actually feels like having a full stop at the end of a comment like this is actively wrong -- it changes it from one type of speech into another type of speech. I wouldn't bike-shed over the issue by insisting a full stop be removed; but it would definitely irritate me to be told that I had to add one. --- -George _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel