On 11/08/16 19:16, Boris Ostrovsky wrote: > On 08/11/2016 12:40 PM, Wei Liu wrote: >> On Thu, Aug 04, 2016 at 05:06:51PM -0400, Boris Ostrovsky wrote: >>> Load ACPI modules into guest space >>> >>> Signed-off-by: Boris Ostrovsky <boris.ostrov...@oracle.com> >>> --- >>> v2: >>> * New patch, loosely based on Shannon's ARM patch >>> >>> tools/libxc/xc_dom_core.c | 92 >>> +++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 92 insertions(+) >>> >>> diff --git a/tools/libxc/xc_dom_core.c b/tools/libxc/xc_dom_core.c >>> index ebada89..00d870f 100644 >>> --- a/tools/libxc/xc_dom_core.c >>> +++ b/tools/libxc/xc_dom_core.c >>> @@ -1040,6 +1040,94 @@ static int xc_dom_build_ramdisk(struct xc_dom_image >>> *dom) >>> return -1; >>> } >>> >>> +static int populate_acpi_pages(struct xc_dom_image *dom, >>> + xen_pfn_t *extents, >>> + unsigned int num_pages) >>> +{ >>> + int rc; >>> + xc_interface *xch = dom->xch; >>> + uint32_t domid = dom->guest_domid; >>> + unsigned long idx, first_high_idx = (1ull << (32 - 12)); >>> + >> Maybe eliminate these magic numbers? > Well, at least 12 was supposed to be PAGE_SHIFT.
looks like this should be s/idx/pfn/g and (GB(4) >> PAGE_SHIFT) ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel