On Tue, Sep 06, 2016 at 07:25:23PM +0100, Andrew Cooper wrote: > On 06/09/16 18:22, Konrad Rzeszutek Wilk wrote: > > On Tue, Aug 23, 2016 at 10:22:12PM -0400, Konrad Rzeszutek Wilk wrote: > >> From: Ross Lagerwall <ross.lagerw...@citrix.com> > >> > >> Add hook functions which run during patch apply and patch revert. > >> Hook functions are used by livepatch payloads to manipulate data > >> structures during patching, etc. > >> > >> One use case is the XSA91. As Martin mentions it: > >> "If we have shadow variables, we also need an unload hook to garbage > >> collect all the variables introduced by a hotpatch to prevent memory > >> leaks. Potentially, we also want to pre-reserve memory for static or > >> existing dynamic objects in the load-hook instead of on the fly. > >> > >> For testing and debugging, various applications are possible. > >> > >> In general, the hooks provide flexibility when having to deal with > >> unforeseen cases, but their application should be rarely required (< > >> 10%)." > >> > >> Furthermore include a test-case for it. > >> > >> Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> > >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > > > > So... anybody willing to review it :-) > > > >> --- > >> Cc: Andrew Cooper <andrew.coop...@citrix.com> > >> Cc: George Dunlap <george.dun...@eu.citrix.com> > >> Cc: Ian Jackson <ian.jack...@eu.citrix.com> > >> Cc: Jan Beulich <jbeul...@suse.com> > >> Cc: Stefano Stabellini <sstabell...@kernel.org> > >> Cc: Tim Deegan <t...@xen.org> > >> Cc: Wei Liu <wei.l...@citrix.com> > > > > In regards to this going in v4.8 my recollection is that: > > > > George: 0 > > Andrew: +1 > > Jan: 0 (with a slight leaning towards -1)? > > > > I think that means folks are OK or 'don't care'. > > > > And the livepatch maintainers: > > Ross: +1 (obviously since he wrote it) > > Konrad: +1 > > Reviewed-by: Andrew Cooper <andrew.coop...@citrix.com>
Thank you! If nobody objects I will push this patch (along with some other ones that have been Reviewed) on Friday morning. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
