On Thu, Sep 8, 2016 at 9:50 AM, Lai, Paul C <paul.c....@intel.com> wrote: > [Paul] in-line > > -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Thursday, September 8, 2016 7:47 AM > To: Lai, Paul C <paul.c....@intel.com> > Cc: george.dun...@citrix.com; Sahita, Ravi <ravi.sah...@intel.com>; xen-devel > <xen-de...@lists.xenproject.org> > Subject: Re: [PATCH Altp2m cleanup v4 2/4] altp2m cleanup work > >>>> On 08.09.16 at 00:04, <paul.c....@intel.com> wrote: >> Indent goto labels by one space >> Inline (header) altp2m functions >> Define default behavior in switch >> Define max and min for range of altp2m macroed values >> >> Signed-off-by: Paul Lai <paul.c....@intel.com> >> --- > > Missing a brief summary of changes from previous version here. > >> @@ -5413,6 +5426,8 @@ static int do_altp2m_op( >> rc = p2m_change_altp2m_gfn(d, a.u.change_gfn.view, >> _gfn(a.u.change_gfn.old_gfn), >> _gfn(a.u.change_gfn.new_gfn)); >> + default: >> + ASSERT_UNREACHABLE(); >> } > > Did you test anything using HVMOP_altp2m_change_gfn with this change, on a > debug build? There's obviously an unintended fall- through right now. > > [Paul] - Yes, this patch series was tested with Tamas's > HVMOP_altp2m_change_gfn in a debug build.
Not sure what you used here, the xen-access tool right now in Xen doesn't (yet) exercise the gfn remapping, only the mem-access parts. Sergej has a patch for this in the arm-altp2m series though. Tamas _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
