Clang complains nr_dom_vcpus may be used uninitialised after 4a6070ea9. The real issue is vinfo can be NULL and nr_dom_vcpus remains uninitialised if previous call fails.
Initialise nr_dom_vcpus to 0 at the beginning of the loop to fix the issue. Signed-off-by: Wei Liu <wei.l...@citrix.com> --- Cc: Ian Jackson <ian.jack...@eu.citrix.com> Cc: Dario Faggioli <dario.faggi...@citrix.com> Cc: Juergen Gross <jgr...@suse.com> --- tools/libxl/libxl_numa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/libxl/libxl_numa.c b/tools/libxl/libxl_numa.c index fd64c22..a8a75f8 100644 --- a/tools/libxl/libxl_numa.c +++ b/tools/libxl/libxl_numa.c @@ -206,8 +206,9 @@ static int nr_vcpus_on_nodes(libxl__gc *gc, libxl_cputopology *tinfo, for (i = 0; i < nr_doms; i++) { libxl_vcpuinfo *vinfo = NULL; + int nr_dom_vcpus = 0; libxl_cpupoolinfo cpupool_info; - int cpupool, nr_dom_vcpus; + int cpupool; libxl_cpupoolinfo_init(&cpupool_info); -- 2.1.4 _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel