> -----Original Message----- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: Friday, October 28, 2016 9:18 PM > To: Wu, Feng <feng...@intel.com> > Cc: andrew.coop...@citrix.com; dario.faggi...@citrix.com; > george.dun...@eu.citrix.com; Tian, Kevin <kevin.t...@intel.com>; xen- > de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH v6 1/7] VMX: Permanently assign PI hook > vmx_pi_switch_to() > > >>> On 28.10.16 at 15:04, <jbeul...@suse.com> wrote: > >>>> On 28.10.16 at 04:37, <feng...@intel.com> wrote: > >> --- a/xen/arch/x86/hvm/vmx/vmx.c > >> +++ b/xen/arch/x86/hvm/vmx/vmx.c > >> @@ -221,9 +221,14 @@ void vmx_pi_hooks_deassign(struct domain *d) > >> ASSERT(d->arch.hvm_domain.vmx.vcpu_block); > >> > >> d->arch.hvm_domain.vmx.vcpu_block = NULL; > >> - d->arch.hvm_domain.vmx.pi_switch_from = NULL; > >> - d->arch.hvm_domain.vmx.pi_switch_to = NULL; > > > > And with the commit message as it is right now, it is completely > > unclear why the from hook also gets zapped. In fact, with the > > description pointing out a problem with just the SN=1 case, I > > don't see what you need the from hook for without devices > > assigned, as that's where SN gets set (and you want to avoid > > that). > > > >> d->arch.hvm_domain.vmx.pi_do_resume = NULL; > >> + d->arch.hvm_domain.vmx.pi_switch_from = NULL; > > Oh, I'm sorry - I paid attention only to the lines getting removed > above, not the one line getting re-inserted here. That addresses > my comment, of course; I just can't see why the line needs to be > moved.
Yes, we could just reuse the original line. Thanks! Thanks, Feng > > Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel