>>> Wei Liu <wei.l...@citrix.com> 11/01/16 5:20 PM >>> >On Tue, Nov 01, 2016 at 10:18:46AM -0600, Jan Beulich wrote: >> >>> Wei Liu <wei.l...@citrix.com> 11/01/16 2:48 PM >>> >> >config/StdGNU.mk | 8 -------- >> >config/SunOS.mk | 7 ------- >> >tools/Rules.mk | 4 +++- >> >xen/Rules.mk | 6 ++++++ >> >4 files changed, 9 insertions(+), 16 deletions(-) >> >> Considering this diffstat - did the original global settings not get >> inherited >> by any of the other subtrees, namely stubdom/ and/or extras/ ? > >I mentioned this in commit message and deliberately made the decision to >not inherit these flags for stubdom build.
Indeed, I've overlooked that part, but I'm not fully convinced. And then extras/ and possible other subtrees don't get mentioned (at the very least I'd expect a sentence clarifying that no other subtrees are affected, but as said at least for extras/ I'm not sure: That's where mini-os gets linked in, and I don't recall whether its build machinery got fully separated). Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
