On Tue, Nov 08, 2016 at 07:29:01AM +0100, Juergen Gross wrote: > The dependency for setting up the links for ioemu is wrong: it is > depending on tools/qemu-xen-traditional-dir which is being modified by > each "make tools" call. This leads to rebuilds of several stubdom > libraries for each call of "make stubdom" as those depend on the ioemu > linkfarm stamp file. > > Modify the dependency to the qemu Makefile instead which is a better > indicator whether we need to create the qemu directory before setting > up the links. > > Signed-off-by: Juergen Gross <jgr...@suse.com> > --- > stubdom/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/stubdom/Makefile b/stubdom/Makefile > index 2921f30..0b33e23 100644 > --- a/stubdom/Makefile > +++ b/stubdom/Makefile > @@ -281,10 +281,10 @@ IOEMU_LINKFARM_TARGET := ioemu/linkfarm.stamp > endif > > ifeq ($(QEMU_ROOT),.) > -$(XEN_ROOT)/tools/qemu-xen-traditional-dir: > +$(XEN_ROOT)/tools/qemu-xen-traditional-dir/Makefile: > $(MAKE) DESTDIR= -C $(XEN_ROOT)/tools qemu-xen-traditional-dir-find >
What happens if you modify qemu-trad source file(s) and then rebuild stubdom? Will that work correctly after this patch is applied? > -ioemu/linkfarm.stamp: $(XEN_ROOT)/tools/qemu-xen-traditional-dir > +ioemu/linkfarm.stamp: $(XEN_ROOT)/tools/qemu-xen-traditional-dir/Makefile > mkdir -p ioemu > set -e; > \ > $(buildmakevars2shellvars); > \ > -- > 2.6.6 > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
