On November 12, 2016 4:14:50 AM EST, "Wu, Feng" <feng...@intel.com> wrote: >> > diff --git a/xen/arch/x86/hvm/vmx/vmx.c >b/xen/arch/x86/hvm/vmx/vmx.c >> > index 3d330b6..10546af 100644 >> > --- a/xen/arch/x86/hvm/vmx/vmx.c >> > +++ b/xen/arch/x86/hvm/vmx/vmx.c >> > @@ -222,8 +222,13 @@ void vmx_pi_hooks_deassign(struct domain *d) >> > >> > d->arch.hvm_domain.vmx.vcpu_block = NULL; >> > d->arch.hvm_domain.vmx.pi_switch_from = NULL; >> > - d->arch.hvm_domain.vmx.pi_switch_to = NULL; >> > d->arch.hvm_domain.vmx.pi_do_resume = NULL; >> > + >> > + /* >> > + * In fact, we could remove 'vmx_pi_switch_to' inside itself >if no new >> device >> >> I am having a hard time parsing that. What is the 'inside itself'? > >Thanks for your review. It means we could set ' >d->arch.hvm_domain.vmx.pi_switch_to' >to NULL in vmx_pi_switch_to(). It would be good if you have any better >description! :)
Your above description is perfect: "We could set d-arch.hvm_domain.vmx.pi_switch_to to NULL in vmx_pi_switch_to() if no new device ..." Thanks! _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel