On 11/21/2016 10:32 AM, Andrew Cooper wrote: > The variable is named inst_len, not insn_len. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com> > --- > CC: Jan Beulich <jbeul...@suse.com> > CC: Wei Liu <wei.l...@citrix.com> > CC: Boris Ostrovsky <boris.ostrov...@oracle.com> > CC: Suravee Suthikulpanit <suravee.suthikulpa...@amd.com> > > I definitely fixed this once duing development, but it clearly slipped back > in. My appologies. > --- > xen/arch/x86/hvm/svm/emulate.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/hvm/svm/emulate.c b/xen/arch/x86/hvm/svm/emulate.c > index ca670bf..2b47db9 100644 > --- a/xen/arch/x86/hvm/svm/emulate.c > +++ b/xen/arch/x86/hvm/svm/emulate.c > @@ -98,8 +98,8 @@ int __get_instruction_length_from_list(struct vcpu *v, > */ > #ifdef NDEBUG > if ( (inst_len = svm_nextrip_insn_length(v)) > MAX_INST_LEN ) > - gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", insn_len); > - else if ( insn_len != 0 ) > + gprintk(XENLOG_WARNING, "NRip reported insn_len %lu\n", inst_len);
Since you are fixing this up anyway, insn_let in format string should also be updated. With that, Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> > + else if ( inst_len != 0 ) > return inst_len; > > if ( vmcb->exitcode == VMEXIT_IOIO ) _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel