* Alex Thorlton <athorl...@sgi.com> wrote: > It's really not necessary to limit E820_X_MAX to 128 in the non-EFI > case. This commit drops E820_X_MAX's dependency on CONFIG_EFI, so that > E820_X_MAX is always at least slightly larger than E820MAX. > > The real motivation behind this is actually to prevent some issues in > the Xen kernel, where the XENMEM_machine_memory_map hypercall can > produce an e820 map larger than 128 entries, even on systems where the > original e820 table was quite a bit smaller than that, depending on how > many IOAPICs are installed on the system. > > Signed-off-by: Alex Thorlton <athorl...@sgi.com> > Suggested-by: Ingo Molnar <mi...@redhat.com> > Cc: Russ Anderson <r...@sgi.com> > Cc: David Vrabel <david.vra...@citrix.com> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: Juergen Gross <jgr...@suse.com> > Cc: Thomas Gleixner <t...@linutronix.de> > Cc: "H. Peter Anvin" <h...@zytor.com> > Cc: Denys Vlasenko <dvlas...@redhat.com> > Cc: Boris Ostrovsky <boris.ostrov...@oracle.com> > Cc: x...@kernel.org > Cc: xen-de...@lists.xenproject.org > --- > arch/x86/include/asm/e820.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/include/asm/e820.h b/arch/x86/include/asm/e820.h > index 476b574..aa00d33 100644 > --- a/arch/x86/include/asm/e820.h > +++ b/arch/x86/include/asm/e820.h > @@ -1,13 +1,15 @@ > #ifndef _ASM_X86_E820_H > #define _ASM_X86_E820_H > > -#ifdef CONFIG_EFI > +/* > + * We need to make sure that E820_X_MAX is defined > + * before we include uapi/asm/e820.h > + */ > #include <linux/numa.h> > #define E820_X_MAX (E820MAX + 3 * MAX_NUMNODES)
What we need an explanation for in the comment is what does this stand for (what does the 'X' mean?), and what is the magic 3*MAX_NUMNODES about? Thanks, Ingo _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel