>>> On 06.12.16 at 17:35, <andrew.coop...@citrix.com> wrote: > On 06/12/16 13:39, Jan Beulich wrote: >> @@ -5424,7 +5436,6 @@ x86_emulate( >> goto cannot_emulate; >> } >> >> - writeback: > > This removal highlights that the writeback and no_writeback lables are > incorrectly named. > > There intended meaning is {no,}dest_writeback, but no_writeback still > performs a full commit of the shadow GPR state, which is what people > logically associate with the term "writeback" in this context. > > I think we should have a followup patch renaming the no_writeback label > to to gpr_writeback.
I've done this, but for some of the uses of the label the new name doesn't appear to be much better than the old one ... Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel