Jan Beulich writes ("Re: [PATCH 5/8] libelf: loop safety: Replace all calls to
strcmp"):
> On 09.12.16 at 16:44, <ian.jack...@eu.citrix.com> wrote:
> > /* other */
> > - if ( !strcmp(name, "FEATURES") )
> > - if ( elf_xen_parse_features(value, parms->f_supported,
> > + if ( !elf_strcmp_safe(elf, name, "FEATURES") )
> > + if ( elf_xen_parse_features(elf, value, parms->f_supported,
> > parms->f_required) )
> > return -1;
>
> There must be some patch split problem here - this patch does not
> alter the parameters of elf_xen_parse_features(), so the argument
> list can't change here.
Yes. That part of this hunk should be in
libelf: loop safety: Pass `elf' to elf_xen_parse_features
I thought I had done a compile test of that individual patch but
I must have messed that up somehow. I will move that change.
> And one of the then (at least) two patches touching this code could
> then take the opportunity and fold the two if()s into one.
Looking at the surrounding code, I actually prefer it the way it is.
It makes it more like the other similar test/handle pairs.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
