On 12/20/2016 08:24 AM, Jan Beulich wrote: > >> -static int acpi_access_common(struct domain *d, >> +static int acpi_access_common(struct domain *d, bool is_guest_access, > Why? I thought the domctl is needed only for updating the CPU > map? Or maybe it would help if the patch had a non-empty > description.
domctl updates both the map and the status. I.e. in the toolstack it looks like /*Update VCPU map. */ rc = xc_acpi_iowrite(CTX->xch, domid, XEN_ACPI_CPU_MAP, cpumap->size, cpumap->map); if (!rc) { /* Send an SCI. */ uint16_t val = 1 << XEN_ACPI_GPE0_CPUHP_BIT; rc = xc_acpi_iowrite(CTX->xch, domid, ACPI_GPE0_BLK_ADDRESS_V1, sizeof(val), &val); } I'll make a note in the commit message of the fact that both are accessed. OTOH, maybe we should have an update to the map trigger the SCI and not require the toolstack to do so? -boris _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel