On 12/01/17 14:13, Jan Beulich wrote: >>>> On 12.01.17 at 15:02, <andrew.coop...@citrix.com> wrote: >> I did make get_cpu_vendor() quite a lot better than it was previously, >> but it is still searching a loop. For the extra 3 bytes of data, I >> still think pre-calculating the values is worth it. > Well, as said, the question isn't the extra amount of data, but the > redundancy (and hence risk of going out of sync). Could we meet > in the middle and agree on just caching vendor, but not the other > two items?
I was considering that. Family is only used when writing to cf8, and is far less overhead to recalculate than vendor, as it is straight arithmetic on a uint32_t. I will split the patch in two and go down this route. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel