>>> On 13.01.17 at 20:21, <car...@cardoe.com> wrote: > Doug v1 - fix incorrect assembly (identified by Andrew Cooper) > - fix issue where the trampoline size was left as 0 and the > way the memory is allocated for the trampolines we would go to > the end of an available section and then subtract off the size > to decide where to place it. The end result was that we would > always copy the trampolines and the 32-bit stack into some > form of reserved memory after the conventional region we > wanted to put things into. On some systems this did not > manifest as a crash while on others it did. Reworked the > changes to always reserve 64kb for both the stack and the size > of the trampolines. Added an ASSERT to make sure we never blow > through this size.
Without having looked at the patch in detail, but knowing I did closely look at earlier versions (and iirc I was mostly fine with v10) the way the above is written would require me to either inter-diff the patches, or re-review the whole thing. For a large patch like this it would be rather helpful to be quite a bit more specific as to where exactly in the patch changes were made. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
