On 01/19/2017 03:25 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Quite a few users of qdict_put() were manually wrapping a >> non-QObject. We can make such call-sites shorter, by providing >> common macros to do the tedious work. Also shorten nearby >> qdict_put_obj(,,QOBJECT()) sequences. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> Reviewed-by: Alberto Garcia <be...@igalia.com> >> >> --- >> >> v2: rebase to current master >> >> I'm okay if you want me to break this patch into smaller pieces. > > I guess I'm okay with a single piece, but I'd like to know how you did > the conversion. Coccinelle? Manually?
Manual, via grepping for put_obj.*QOBJECT. I'll see if I can do the same under Coccinelle (at which point, committing the script will make it easier to rerun cleanups if later code reintroduces poor usage patterns), so maybe I have a v3 coming up. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
