On Fri, Jan 27, 2017 at 05:22:03PM +0000, Roger Pau Monne wrote: > On Thu, Jan 26, 2017 at 06:37:00AM -0700, Jan Beulich wrote: > > >>> On 19.01.17 at 18:29, <roger....@citrix.com> wrote: > > > + if ( cmdline != NULL ) > > > + { > > > + rc = hvm_copy_to_guest_phys_vcpu(last_addr, cmdline, > > > + strlen(cmdline) + 1, v); > > > + if ( rc ) > > > + { > > > + printk("Unable to copy guest command line\n"); > > > + return rc; > > > + } > > > + start_info.cmdline_paddr = last_addr; > > > + last_addr += ROUNDUP(strlen(cmdline) + 1, 8); > > > > Where is this 8 coming from? > > So that the next struct is aligned to the cache line size? It's also done in > xc_dom_x86.c.
Sorry, not to the cache, this is just so it's aligned: https://lists.xen.org/archives/html/xen-devel/2015-08/msg01883.html Roger. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel