On 31/01/17 13:40, Jan Beulich wrote: >>>> On 31.01.17 at 14:22, <wei.l...@citrix.com> wrote: >> Starting from ee3e265688, $(CC) is used for linking. That means all >> default $(CC) flags coming from distro takes effect. > First of all I think $(CC) containing any flags is wrong - that's what > $(CFLAGS) is for. Or are you saying the compiler's built in default is > to generate PIE?
I believe Wei is referring to this latter case. > And then in an environment like xtf or the hypervisor > (or kernels in general) such preset flags should imo simply be discarded. > I.e. CFLAGS should start out all blank. The XTF build system constructs $(CFLAGS) itself. > So if PIE simply is the compiler default, I'd suppose there's a way to > find out, and that could be leveraged for adding -no-pie. Otherwise > conditional option adding will need to be used (not sure whether xtf > has already inherited Xen's macros for this). I haven't needed any of the conditional option logic yet, which is why nothing is there. If we can't unconditionally use -no-pie, then it looks like we will need to gain some conditional logic. ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
