>>> On 31.01.17 at 15:36, <wei.l...@citrix.com> wrote: > On Tue, Jan 31, 2017 at 05:50:09AM -0700, Jan Beulich wrote: >> >>> On 31.01.17 at 12:08, <wei.l...@citrix.com> wrote: >> > --- a/tools/tests/x86_emulator/x86_emulate.h >> > +++ b/tools/tests/x86_emulator/x86_emulate.h >> > @@ -6,6 +6,8 @@ >> > #include <string.h> >> > #include <xen/xen.h> >> > >> > +#include "../../../xen/include/asm-x86/x86-vendors.h" >> >> I think we'd better avoid includes of this style. May I suggest >> symlinking the needed headers, just like we already do with the >> x86_emulate/x86_emulate[ch] files (perhaps to an include/ >> subdirectory in the build tree)? > > I will just link this (and later headers) to tools/tests/x86_emulator -- > using a dedicated directory is not strictly necessary.
Hmm, for consistency with hypervisor #include directives, linking to asm/ (and adding -I. to CFLAGS) might be a good idea. Jan _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
