On Wed, Feb 01, 2017 at 01:13:44PM +0000, Andrew Cooper wrote: > On 01/02/17 13:09, Jan Beulich wrote: > >>>> On 01.02.17 at 13:02, <wei.l...@citrix.com> wrote: > >> --- a/tools/fuzz/x86_instruction_emulator/Makefile > >> +++ b/tools/fuzz/x86_instruction_emulator/Makefile > >> @@ -11,10 +11,15 @@ endif > >> x86_emulate/x86_emulate.c x86_emulate/x86_emulate.h: > >> [ -L x86_emulate ] || ln -sf $(XEN_ROOT)/xen/arch/x86/x86_emulate . > >> > >> +asm/x86-vendors.h: > >> + [ -L asm ] || ln -sf $(XEN_ROOT)/xen/include/asm-x86 asm > > Hmm, that's making all headers available. I don't really like it to > > be that broad. Andrew, what do you think > > This is just a test utility. I think we can trust ourselves to only > include appropriate headers. > > This is simpler and easier than keeping a whitelist of permitted > headers, which doesn't require any modification when we add a new header. >
Yes, this is exactly the reason why I did it like this. Wei. > ~Andrew _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel