On Wed, Feb 15, 2017 at 04:49:17PM +0800, Yi Sun wrote: > The current cache allocation codes in psr.c do not consider > future features addition and are not friendly to extend. > > To make psr.c be more flexible to add new features and fulfill > the program principle, open for extension but closed for > modification, we have to refactor the psr.c: > 1. Analyze cache allocation features and abstract general data > structures. > 2. Analyze the init and all other functions flow, abstract all > steps that different features may have different implementations. > Make these steps be callback functions and register feature > specific fuctions. Then, the main processes will not be changed > when introducing a new feature. > > Because the quantity of refactor codes is big and the logics are > changed a lot, it will cause reviewers confused if just change > old codes. Reviewers have to understand both old codes and new > implementations. After review iterations from V1 to V3, Jan has > proposed to remove all old cache allocation codes firstly, then > implement new codes step by step. This will help to make codes > be more easily reviewable. > > There is no construction without destruction. So, this patch > removes all current L3 CAT/CDP codes in psr.c. The following > patches will introduce the new mechanism. > > Signed-off-by: Yi Sun <[email protected]> > Acked-by: Jan Beulich <[email protected]> > Reviewed-by: Konrad Rzeszutek Wilk <[email protected]>
Reviewed-by: Wei Liu <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xen.org/xen-devel
