Hi Bhupinder, Commit title: s/atleat/at least/
On 02/21/2017 11:26 AM, Bhupinder Thakur wrote:
Ensure that nr_spis intialized in in vgic_init is atleast 1 to allow allocation of
s/intialized/initialized/ and again s/atleast/at least/
pl011 spi virq. Signed-off-by: Bhupinder Thakur <bhupinder.tha...@linaro.org> --- xen/arch/arm/vgic.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/arch/arm/vgic.c b/xen/arch/arm/vgic.c index 364d5f0..614b3ec 100644 --- a/xen/arch/arm/vgic.c +++ b/xen/arch/arm/vgic.c @@ -121,6 +121,11 @@ int domain_vgic_init(struct domain *d, unsigned int nr_spis) /* Limit the number of virtual SPIs supported to (1020 - 32) = 988 */ if ( nr_spis > (1020 - NR_LOCAL_IRQS) ) return -EINVAL; +#ifdef CONFIG_VPL011_CONSOLE + /* Atleast 1 spi should be available for assigning to vpl011 */ + else if ( nr_spis < (1020 - NR_LOCAL_IRQS) ) + nr_spis += 1; +#endif
Please don't do that. The toolstack should allocated the correct number of SPIs depending on the configuration of the guest.
Cheers, -- Julien Grall _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel