On 01/23/2018 04:05 PM, Ross Lagerwall wrote:
On 01/22/2018 12:29 PM, Jan Beulich wrote:
On 19.01.18 at 17:57, <ross.lagerw...@citrix.com> wrote:
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -511,6 +511,15 @@ static struct dmi_system_id __initdata
reboot_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"),
},
},
+ { /* Handle problems with rebooting on Dell PowerEdge R740. */
+ .callback = override_reboot,
+ .driver_data = (void *)(long)BOOT_ACPI,
+ .ident = "Dell PowerEdge R740",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+ DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"),
+ },
+ },
Judging from the description you don't really want or need to
override the reboot method if not running under EFI, or if there
was an override on the command line already. override_reboot(),
however, overrides everything and under all circumstances. I
therefore think you may want to introduce a new callback
function.
Agreed, it should only apply when running under EFI. Note that the
command-line takes priority over override_reboot() -- see the note at
the start of reboot_init().
Actually, now that I think about it, this quirk would have no effect
when not running under EFI since in either case, the quirk uses
BOOT_ACPI unless acpi_disabled is set in which case it uses BOOT_KBD.
This matches what default_reboot_type() does. So I think this patch is
fine and no further changes are needed unless I'm missing something?
Thanks,
--
Ross Lagerwall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel