> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Tuesday, February 27, 2018 1:35 AM > > The default case of vmx_msr_write_intercept() in particular is very tangled. > > First of all, fold long_mode_do_msr_{read,write}() into their callers. These > functions were split out in the past because of the 32bit build of Xen, but it > is unclear why the cases weren't simply #ifdef'd in place. > > Next, invert the vmx_write_guest_msr()/is_last_branch_msr() logic to break > if > the condition is satisfied, rather than nesting if it wasn't. This allows the > wrmsr_hypervisor_regs() call to be un-nested with respect to the other > default > logic. > > No practical difference from a guests point of view. > > Signed-off-by: Andrew Cooper <andrew.coop...@citrix.com>
Acked-by: Kevin Tian <kevin.t...@intel.com> _______________________________________________ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel