On Tue, Mar 13, 2018 at 02:23:15PM +0000, Roger Pau Monné wrote:
> On Mon, Mar 05, 2018 at 11:36:58AM +0000, Ian Jackson wrote:
> > Roger Pau Monne writes ("[PATCH] xl: remove apic option for PVH guests"):
> > > XSA-256 forces the local APIC to always be enabled for PVH guests, so
> > > ignore any apic option for PVH guests. Update the documentation
> > > accordingly.
> > ...
> > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c
> > > index f6842540ca..8b999825d2 100644
> > > --- a/tools/xl/xl_parse.c
> > > +++ b/tools/xl/xl_parse.c
> > > @@ -1208,7 +1208,6 @@ void parse_config_data(const char *config_source,
> > > }
> > >
> > > xlu_cfg_get_defbool(config, "nestedhvm", &b_info->nested_hvm, 0);
> > > - xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
> >
> > Is this hunk not in a path also used by HVM ?
>
> Yes, this hunk is moved to a HVM-specific section a little bit below:
>
> @@ -1243,6 +1242,7 @@ void parse_config_data(const char *config_source,
> xlu_cfg_get_defbool(config, "nx", &b_info->u.hvm.nx, 0);
> xlu_cfg_get_defbool(config, "hpet", &b_info->u.hvm.hpet, 0);
> xlu_cfg_get_defbool(config, "vpt_align", &b_info->u.hvm.vpt_align,
> 0);
> + xlu_cfg_get_defbool(config, "apic", &b_info->apic, 0);
>
> switch (xlu_cfg_get_list(config, "viridian",
> &viridian, &num_viridian, 1))
>
> So it's only set for HVM, which AFAICT should be fine.
>
I tried to apply this patch to staging but it failed.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
