On Fri, 16 Mar 2018, Julien Grall wrote: > On 16/03/2018 21:34, Stefano Stabellini wrote: > > On Thu, 15 Mar 2018, Andre Przywara wrote: > > > From: Julien Grall <[email protected]> > > > diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h > > > index daec51499c..c32861d4fa 100644 > > > --- a/xen/include/asm-arm/gic.h > > > +++ b/xen/include/asm-arm/gic.h > > > @@ -209,7 +209,8 @@ struct gic_lr { > > > /* Virtual IRQ */ > > > uint32_t virq; > > > uint8_t priority; > > > - uint8_t state; > > > + bool active; > > > + bool pending; > > > bool hw_status; > > > }; > > > > I like the readability but dislike the increase memory usage. I would > > have kept a single uint8_t and I would have used status flags as an > > approach, maybe I would have improved on those flags. > > Why is that important? gic_lr will only be allocated on the stack...
You are right, so it is even less important than I thought. Acked-by: Stefano Stabellini <[email protected]> _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
